Summary
grid_map_filters appears to use grid_map_cv directly in production/runtime code, but grid_map_cv is not declared directly in grid_map_filters/package.xml in humble branch.
The package currently remains buildable because the dependency is reachable through the recursive dependency closure. This issue is about making the direct dependency contract match the source usage, not claiming that the current default build necessarily fails.
Direct source usage
grid_map_filters directly includes grid_map_cv in the following source locations:
src/ColorFillFilter.cpp:18: #include "grid_map_cv/utilities.hpp"
src/CurvatureFilter.cpp:18: #include "grid_map_cv/utilities.hpp"
src/MathExpressionFilter.cpp:16: #include "grid_map_cv/utilities.hpp"
src/MinInRadiusFilter.cpp:16: #include "grid_map_cv/utilities.hpp"
src/DeletionFilter.cpp:16: #include "grid_map_cv/utilities.hpp"
src/NormalColorMapFilter.cpp:18: #include "grid_map_cv/utilities.hpp"
src/ColorMapFilter.cpp:20: #include "grid_map_cv/utilities.hpp"
src/MeanInRadiusFilter.cpp:16: #include "grid_map_cv/utilities.hpp"
The included headers provide concrete types or APIs that are used by the package:
src/ColorFillFilter.cpp:39: ParameterReader param_reader(this->param_prefix_, this->params_interface_);
src/CurvatureFilter.cpp:36: ParameterReader param_reader(this->param_prefix_, this->params_interface_);
src/MathExpressionFilter.cpp:34: ParameterReader param_reader(this->param_prefix_, this->params_interface_);
src/MinInRadiusFilter.cpp:35: ParameterReader param_reader(this->param_prefix_, this->params_interface_);
src/DeletionFilter.cpp:34: ParameterReader param_reader(this->param_prefix_, this->params_interface_);
src/NormalColorMapFilter.cpp:36: ParameterReader param_reader(this->param_prefix_, this->params_interface_);
src/ColorMapFilter.cpp:40: ParameterReader param_reader(this->param_prefix_, this->params_interface_);
src/MeanInRadiusFilter.cpp:35: ParameterReader param_reader(this->param_prefix_, this->params_interface_);
Package metadata
The collected package metadata and raw package.xml context contain no direct declaration of grid_map_cv. The appropriate declaration is likely <depend>grid_map_cv</depend>, subject to the package maintainer's preferred dependency scope.
Build/test trace observation
Build/test file-access tracing observed some events associated with grid_map_cv during build;test. Observed artifact kinds were ament_resource;other.
Representative accessed paths include:
grid_map_cv/share/ament_index/resource_index/package_run_dependencies/grid_map_cv
grid_map_cv/share/grid_map_cv/package.sh
grid_map_cv/share/grid_map_cv/hook/cmake_prefix_path.sh
grid_map_cv/share/grid_map_cv/hook/ld_library_path_lib.sh
Transitive path
grid_map_filters -> grid_map_ros -> grid_map_cv
Suggested fix
Would it make sense to declare grid_map_cv directly in grid_map_filters/package.xml and, where needed by the package's build style, add the corresponding CMake dependency to the target that uses it?
Notes
This issue does not claim that the package currently fails to build. The concern is that the package directly uses grid_map_cv while relying on a transitive dependency path to make it available. The evidence combines package metadata, concrete source-level use, recursive dependency closure analysis, and build/test file-access tracing.
Could you please confirm whether this dependency is intentionally left implicit, or whether an explicit declaration would be appropriate?
I would be happy to open a small PR adding the dependency if that matches the intended package metadata.
Summary
grid_map_filtersappears to usegrid_map_cvdirectly in production/runtime code, butgrid_map_cvis not declared directly ingrid_map_filters/package.xmlinhumblebranch.The package currently remains buildable because the dependency is reachable through the recursive dependency closure. This issue is about making the direct dependency contract match the source usage, not claiming that the current default build necessarily fails.
Direct source usage
grid_map_filtersdirectly includesgrid_map_cvin the following source locations:src/ColorFillFilter.cpp:18:#include "grid_map_cv/utilities.hpp"src/CurvatureFilter.cpp:18:#include "grid_map_cv/utilities.hpp"src/MathExpressionFilter.cpp:16:#include "grid_map_cv/utilities.hpp"src/MinInRadiusFilter.cpp:16:#include "grid_map_cv/utilities.hpp"src/DeletionFilter.cpp:16:#include "grid_map_cv/utilities.hpp"src/NormalColorMapFilter.cpp:18:#include "grid_map_cv/utilities.hpp"src/ColorMapFilter.cpp:20:#include "grid_map_cv/utilities.hpp"src/MeanInRadiusFilter.cpp:16:#include "grid_map_cv/utilities.hpp"The included headers provide concrete types or APIs that are used by the package:
src/ColorFillFilter.cpp:39:ParameterReader param_reader(this->param_prefix_, this->params_interface_);src/CurvatureFilter.cpp:36:ParameterReader param_reader(this->param_prefix_, this->params_interface_);src/MathExpressionFilter.cpp:34:ParameterReader param_reader(this->param_prefix_, this->params_interface_);src/MinInRadiusFilter.cpp:35:ParameterReader param_reader(this->param_prefix_, this->params_interface_);src/DeletionFilter.cpp:34:ParameterReader param_reader(this->param_prefix_, this->params_interface_);src/NormalColorMapFilter.cpp:36:ParameterReader param_reader(this->param_prefix_, this->params_interface_);src/ColorMapFilter.cpp:40:ParameterReader param_reader(this->param_prefix_, this->params_interface_);src/MeanInRadiusFilter.cpp:35:ParameterReader param_reader(this->param_prefix_, this->params_interface_);Package metadata
The collected package metadata and raw
package.xmlcontext contain no direct declaration ofgrid_map_cv. The appropriate declaration is likely<depend>grid_map_cv</depend>, subject to the package maintainer's preferred dependency scope.Build/test trace observation
Build/test file-access tracing observed some events associated with
grid_map_cvduringbuild;test. Observed artifact kinds wereament_resource;other.Representative accessed paths include:
grid_map_cv/share/ament_index/resource_index/package_run_dependencies/grid_map_cvgrid_map_cv/share/grid_map_cv/package.shgrid_map_cv/share/grid_map_cv/hook/cmake_prefix_path.shgrid_map_cv/share/grid_map_cv/hook/ld_library_path_lib.shTransitive path
Suggested fix
Would it make sense to declare
grid_map_cvdirectly ingrid_map_filters/package.xmland, where needed by the package's build style, add the corresponding CMake dependency to the target that uses it?Notes
This issue does not claim that the package currently fails to build. The concern is that the package directly uses
grid_map_cvwhile relying on a transitive dependency path to make it available. The evidence combines package metadata, concrete source-level use, recursive dependency closure analysis, and build/test file-access tracing.Could you please confirm whether this dependency is intentionally left implicit, or whether an explicit declaration would be appropriate?
I would be happy to open a small PR adding the dependency if that matches the intended package metadata.