From 34d5e9bb52fcd3898fc38414ecd13cdab3300b80 Mon Sep 17 00:00:00 2001 From: yurikakan Date: Sat, 5 Sep 2026 20:58:08 -0400 Subject: [PATCH 1/2] bad deep link fixes for volunteer order/request management --- apps/frontend/src/components/foodRequestManagement.tsx | 3 ++- apps/frontend/src/containers/volunteerOrderManagement.tsx | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/frontend/src/components/foodRequestManagement.tsx b/apps/frontend/src/components/foodRequestManagement.tsx index 608d593ab..41825e80b 100644 --- a/apps/frontend/src/components/foodRequestManagement.tsx +++ b/apps/frontend/src/components/foodRequestManagement.tsx @@ -95,9 +95,10 @@ const RequestManagement: React.FC = ({ setCurrentPage(Math.floor(idx / itemsPerPage) + 1); } } else { + setAlertMessage('Request not found.', AlertStatus.ERROR); navigate(location.pathname, { replace: true }); } - }, [initialRequestId, requests, navigate, location]); + }, [initialRequestId, requests, navigate, location, setAlertMessage]); const pantryOptions = [ ...new Set( diff --git a/apps/frontend/src/containers/volunteerOrderManagement.tsx b/apps/frontend/src/containers/volunteerOrderManagement.tsx index f396a2a2b..ff61683b0 100644 --- a/apps/frontend/src/containers/volunteerOrderManagement.tsx +++ b/apps/frontend/src/containers/volunteerOrderManagement.tsx @@ -198,9 +198,10 @@ const VolunteerOrderManagement: React.FC = () => { } } } else { + setAlertMessage('Order not found.', AlertStatus.ERROR); navigate(ROUTES.VOLUNTEER_ORDER_MANAGEMENT, { replace: true }); } - }, [searchParams, statusOrders, navigate]); + }, [searchParams, statusOrders, navigate, setAlertMessage]); // Pre-fill pantry filter from url param, url is kept for back/forward navigation useEffect(() => { From 3b57da39c06c4abdf8afb76e4fcde2e93e381f04 Mon Sep 17 00:00:00 2001 From: yurikakan Date: Sat, 5 Sep 2026 21:35:45 -0400 Subject: [PATCH 2/2] fix: NaN requestId silently skips "Request not found" alert Effect used `!initialRequestId`, which treats NaN as falsy and returns early. Malformed ?requestId= values became NaN via Number(), so the alert never fired. Check for undefined explicitly instead. Co-Authored-By: Claude Sonnet 5 --- apps/frontend/src/components/foodRequestManagement.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/frontend/src/components/foodRequestManagement.tsx b/apps/frontend/src/components/foodRequestManagement.tsx index 41825e80b..62ddb0805 100644 --- a/apps/frontend/src/components/foodRequestManagement.tsx +++ b/apps/frontend/src/components/foodRequestManagement.tsx @@ -78,7 +78,7 @@ const RequestManagement: React.FC = ({ }, [selectedFilteredPantries]); useEffect(() => { - if (!initialRequestId || requests.length === 0) return; + if (initialRequestId === undefined || requests.length === 0) return; const match = requests.find((r) => r.requestId === initialRequestId); if (match) {