Skip to content

Commit f316271

Browse files
committed
refactor: improve parameter decryption logging and fallback handling
1 parent b4f68df commit f316271

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

src/main/java/com/codetotime/eppclient/config/EppParams.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,9 @@ public static String getParameter(String key) {
7979
if (decryptedValue != null && !decryptedValue.isEmpty()) {
8080
parameterValue = decryptedValue;
8181
log.debug("Successfully decrypted parameter: {}", key);
82-
} else {
83-
log.warn("Decrypted value is empty for key {}, falling back to resource bundle", key);
84-
throw new Exception("Decrypted value is empty");
8582
}
8683
} catch (Exception decryptEx) {
87-
log.warn(
84+
log.debug(
8885
"Decryption failed for key {}, falling back to resource bundle: {}",
8986
key,
9087
decryptEx.getMessage());
@@ -94,10 +91,12 @@ public static String getParameter(String key) {
9491

9592
// Final check: if parameterValue is still empty, use resource bundle
9693
if (parameterValue.isEmpty()) {
97-
log.debug("Parameter value is empty for key {}, loading from resource bundle", key);
9894
try {
9995
parameterValue = RESOURCE_BUNDLE.getString(key);
100-
log.debug("Loaded parameter from resource bundle: {}", key);
96+
log.warn(
97+
"Decrypted value is empty for key {}, falling back to resource bundle: \"{}\"",
98+
key,
99+
parameterValue);
101100
// Save the fallback value to preferences
102101
setParameter(key, parameterValue);
103102
} catch (MissingResourceException e) {

0 commit comments

Comments
 (0)