Skip to content

Commit 00a587f

Browse files
authored
Merge pull request #656 from Handlebars-Net/fix/sonar-reliability-s3887
fix: resolve SonarCloud reliability regression (A→B) from nullable-references PR
2 parents 2ff8e5c + 9c557e6 commit 00a587f

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

source/Handlebars/Compiler/ClosureBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ public sealed class Closure
160160
public readonly ChainSegment[]? BP0;
161161
public readonly ChainSegment[][]? BPA;
162162

163-
public readonly object?[] A;
163+
public readonly object?[] A; // NOSONAR: public since 2020; reflection-based codegen in this file needs public GetField lookup
164164

165165
internal Closure(
166166
List<KeyValuePair<ConstantExpression, PathInfo>> pathInfos,

source/Handlebars/PathStructure/PathInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ private PathInfo(
105105
/// </summary>
106106
// [MemberNotNullWhen(true, nameof(Segments), nameof(TrimmedPath))]
107107
public readonly bool IsVariable;
108-
public readonly PathSegment[]? Segments;
108+
public readonly PathSegment[]? Segments; // NOSONAR: public since v1.0 (2020); staying public avoids a breaking API change
109109
public readonly string Path;
110110
public readonly string? TrimmedPath;
111111

0 commit comments

Comments
 (0)