Skip to content

Confusion between likelihood and log likelihood #23

Description

@noashin

One of the parameters of pydream.core.run_dream is called "likelihood" and the documentation specify it to be "A user-defined likelihood function".

It seems though that the code is actually expecting a log-likelihood function, as seen in pydream.model.total_logp line 30:

loglike = self.likelihood(q0)

This can be easily solved by changing the parameter name to be log_likelihood and changing the documentation accordingly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions