Skip to content

Commit 41da510

Browse files
authored
Merge pull request #9064 from ProcessMaker/FOUR-33295-b
refactor: optimize group retrieval using query builder
2 parents 4ee9e45 + b6fd1d9 commit 41da510

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

ProcessMaker/Repositories/ProcessExecutionRawRepository.php

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -483,13 +483,12 @@ private function mergeGroupMemberUserIdsRaw(array $groupIds, array &$users): voi
483483

484484
if ($subGroupIds) {
485485
$subGroupIds = array_values(array_unique($subGroupIds));
486-
$groupPlaceholders = implode(',', array_fill(0, count($subGroupIds), '?'));
487-
$activeGroups = DB::select(
488-
"SELECT id FROM `groups` WHERE id IN ($groupPlaceholders) AND status = ?",
489-
array_merge($subGroupIds, ['ACTIVE'])
490-
);
491-
foreach ($activeGroups as $group) {
492-
$pending[] = (int) $group->id;
486+
$activeGroupIds = DB::table('groups')
487+
->whereIn('id', $subGroupIds)
488+
->where('status', 'ACTIVE')
489+
->pluck('id');
490+
foreach ($activeGroupIds as $groupId) {
491+
$pending[] = (int) $groupId;
493492
}
494493
}
495494
}

0 commit comments

Comments
 (0)