Skip to content

feat(frontend): make quote freshness and currency validation explicit in send flow #279

Description

@arisu6804

Problem

Users can confirm a transfer using an expired quote or an amount/currency combination that the backend will reject.

Objective

Deliver a production-quality improvement to FX quote selection, amount entry, and send confirmation that creates measurable value for correctness, security, reliability, performance, or maintainability.

Implementation scope

  • Show quote source, timestamp, expiry, currency metadata, and canonical amount; invalidate on field/network changes; bind quote ID to payload.

Acceptance criteria

  • Expired or mismatched quotes cannot be signed; displayed and serialized amounts reconcile; refresh behavior is clear.

Required validation

  • Expiry, currency matrix, precision, changed-input, and quote-binding tests.
  • Existing tests and CI remain passing.
  • Add regression coverage for the original failure mode.
  • Do not weaken, delete, or skip unrelated tests to obtain a green build.

PR quality bar

  • Keep the PR focused and explain design tradeoffs, compatibility impact, and test evidence.
  • Avoid typo-only, documentation-only, cosmetic-only, or unrelated refactor submissions.

Out of scope

  • Broad rewrites not required by the acceptance criteria.
  • Changes to unrelated services, contracts, or user flows.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    GRANTFOX OSSOpen-source issue tracked by GrantFoxMAYBE REWARDEDThis issue may carry a rewardThird CampaignThird Campaign contributionenhancementNew feature or requestpriority:highHigh implementation priority

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions