From 5b3430378d921280af29405d9eb7c8b05dffe849 Mon Sep 17 00:00:00 2001 From: gonzaloriestra <14979109+gonzaloriestra@users.noreply.github.com> Date: Wed, 12 Aug 2026 00:27:51 +0000 Subject: [PATCH] [Refactor] Simplify isTruthy utility --- packages/cli-kit/src/public/node/context/utilities.test.ts | 6 ++++++ packages/cli-kit/src/public/node/context/utilities.ts | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/cli-kit/src/public/node/context/utilities.test.ts b/packages/cli-kit/src/public/node/context/utilities.test.ts index 98e7ccbc57d..93744534b5d 100644 --- a/packages/cli-kit/src/public/node/context/utilities.test.ts +++ b/packages/cli-kit/src/public/node/context/utilities.test.ts @@ -22,6 +22,12 @@ describe('isTruthy', () => { expect(isTruthy('YES')).toBe(true) }) + test('returns true for mixed case truthy values', () => { + expect(isTruthy('tRuE')).toBe(true) + expect(isTruthy('YEs')).toBe(true) + expect(isTruthy('True')).toBe(true) + }) + test('returns false for "0"', () => { expect(isTruthy('0')).toBe(false) }) diff --git a/packages/cli-kit/src/public/node/context/utilities.ts b/packages/cli-kit/src/public/node/context/utilities.ts index 79c847b67a7..9ab2b302367 100644 --- a/packages/cli-kit/src/public/node/context/utilities.ts +++ b/packages/cli-kit/src/public/node/context/utilities.ts @@ -8,5 +8,5 @@ export function isTruthy(variable: string | undefined): boolean { if (!variable) { return false } - return ['1', 'true', 'TRUE', 'yes', 'YES'].includes(variable) + return ['1', 'true', 'yes'].includes(variable.toLowerCase()) }