From 5320087bd30c4902bf67c0100a48239386de6c0e Mon Sep 17 00:00:00 2001 From: gonzaloriestra <14979109+gonzaloriestra@users.noreply.github.com> Date: Thu, 13 Aug 2026 00:30:00 +0000 Subject: [PATCH 1/2] refactor: remove unused errors property from TomlFile --- packages/cli-kit/src/public/node/toml/toml-file.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/cli-kit/src/public/node/toml/toml-file.ts b/packages/cli-kit/src/public/node/toml/toml-file.ts index 738af367f96..6c3213f5b59 100644 --- a/packages/cli-kit/src/public/node/toml/toml-file.ts +++ b/packages/cli-kit/src/public/node/toml/toml-file.ts @@ -51,7 +51,6 @@ export class TomlFile { readonly path: string content: JsonMapType - readonly errors: TomlFileError[] = [] constructor(path: string, content: JsonMapType) { this.path = path From f941c497b18dad5cf6228b133ef022d05cfa28da Mon Sep 17 00:00:00 2001 From: gonzaloriestra <14979109+gonzaloriestra@users.noreply.github.com> Date: Thu, 13 Aug 2026 00:55:34 +0000 Subject: [PATCH 2/2] refactor: replace reduce with some and every in resolveFramework --- packages/cli-kit/src/public/node/framework.ts | 14 ++++---------- packages/cli-kit/src/public/node/toml/toml-file.ts | 1 + 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/packages/cli-kit/src/public/node/framework.ts b/packages/cli-kit/src/public/node/framework.ts index 0c483c165df..59cccf0f81b 100644 --- a/packages/cli-kit/src/public/node/framework.ts +++ b/packages/cli-kit/src/public/node/framework.ts @@ -154,18 +154,12 @@ export async function resolveFramework(rootDirectory: string): Promise { const matchedFramework = frameworks.find( (framework) => (!framework.detectors.some || - framework.detectors.some.reduce( - (_previousDetectorsMatch: boolean, detector) => - matchDetector(detector, loadFwConfigFile(rootDirectory, detector.path, fwConfigFiles)), - false, + framework.detectors.some.some((detector) => + matchDetector(detector, loadFwConfigFile(rootDirectory, detector.path, fwConfigFiles)), )) && (!framework.detectors.every || - framework.detectors.every.reduce( - (previousDetectorsMatch: boolean, detector) => - previousDetectorsMatch - ? matchDetector(detector, loadFwConfigFile(rootDirectory, detector.path, fwConfigFiles)) - : false, - true, + framework.detectors.every.every((detector) => + matchDetector(detector, loadFwConfigFile(rootDirectory, detector.path, fwConfigFiles)), )), ) diff --git a/packages/cli-kit/src/public/node/toml/toml-file.ts b/packages/cli-kit/src/public/node/toml/toml-file.ts index 6c3213f5b59..738af367f96 100644 --- a/packages/cli-kit/src/public/node/toml/toml-file.ts +++ b/packages/cli-kit/src/public/node/toml/toml-file.ts @@ -51,6 +51,7 @@ export class TomlFile { readonly path: string content: JsonMapType + readonly errors: TomlFileError[] = [] constructor(path: string, content: JsonMapType) { this.path = path