Skip to content

PR #306 closeout: supersede original mega-PR #1

Description

@SnowCheetos

Context

rust-osdev#306 should be treated as an exploration branch. Maintainer feedback was constructive but clear: the branch is too large, too mixed, and has history that blocks review/merge.

Once replacement PRs exist, rust-osdev#306 should be closed or clearly marked as superseded.

Scope

Coordinate the upstream communication around replacing rust-osdev#306 with smaller PRs.

Proposed comment for rust-osdev#306

Thanks, this is fair feedback. I’m going to stop trying to make this branch reviewable as-is and split it up.

Plan:
1. Open a small PR for the platform fixes from the first two commits, without version bumps or generated commit text.
2. Open a separate PR for the global-lock #305 fix and test.
3. Drop or split out the unrelated GIC/resource-descriptor changes.
4. Rebuild the allocator API work on a clean branch, preserving `Global` defaults/`new`, avoiding formatting churn, and writing commit messages that explain the design decisions, especially around `Allocator + Clone`, string storage, and error types.

I’ll treat this PR as an exploration branch and supersede it with smaller reviewable PRs.

Acceptance criteria

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions