ScamBlocker doesn't scan edited messages, allowing scam

[KonstantineVashalomidze]

Describe the bug
ScamBlocker only checks messages when they are first sent (onMessageReceived), but not when they are edited (onMessageUpdated). This means a user can send a clean message nd then edit it to conain scam content, bypassing detection entirely.

Expected behavior
Edited messages should be scanned the same way new messages are. (They should be deleted and reported)

To Reproduce
For example type @everyone $ in any channel, we expect this to be deleted which gets deleted correctly since corresponding combination is considered as scam. Now type for example Meow and then edit it to Meow -> @everyone $. It is not getting deleted.

Screenshots

NOTE: This is my test discord server not ours.

Additional context
The one possible solution is to override onMessageUpdated in ScamBlocker and run the same scam detection logic (as in onMessageReceived) on the edited message content.

[KonstantineVashalomidze]

I intend to work on this, can someone assign it to me?

[christolis]

Personally I believe that this is a minor issue as empirically speaking, most scammers will not edit their messages to perform their scam show. I believe they haven't reached that point yet.

Though it is something that we could prematurely guard against.

[KonstantineVashalomidze]

@christolis I agree. But worth fixing.

[KonstantineVashalomidze]

I have started manual testing of my fix since there is no ScamBlockerTest class in the tests. I will open pull request today.