#3606 shortened the Chinese label for the per-chat thinking-level default from 模型默认 to 默认, and it has been merged — the shorter label is the intended product behaviour.
What is now out of date is the comment that describes the underlying contract. apps/desktop/src/renderer/use-shell-chat-model.ts:111-114 still reads:
Three states, because two cannot say this: undefined is an untouched picker, so Settings → 通用 → 默认思考级别 applies; null is the user explicitly choosing 模型默认 for this one chat, which must beat the configured default or the per-chat picker could not undo it.
So the comment names the option 模型默认 while the UI now shows 默认. That mismatch is worth closing for a concrete reason rather than tidiness: the wording in that comment is what a reviewer reaches for when judging this label, and it will keep producing the same objection — that a bare 默认 cannot distinguish "restore the app default" from "override the app default and follow the model's own." Leaving the comment as-is means re-litigating the decision every time someone reads it.
Suggested scope
Small and self-contained — a good first contribution.
- Update the comment at
use-shell-chat-model.ts:111-114 so it describes the states in terms of the labels that actually ship. The three-state behaviour itself is unchanged and should stay: undefined = untouched picker, so the Settings default applies; null = an explicit per-chat choice that must override the configured default, otherwise the picker cannot undo it.
- While there, check the canonical-ladder comment next to
defaultLevel in packages/ui/src/conversation-copy.ts. It predates the Settings-wide default that #2430 introduced and is the other stale description of this same control.
No behaviour change and no test change is expected. If a reader concludes the contract should change rather than the comment, that is a separate discussion and worth raising here first.
Background
#2430 (ede1f12f3) introduced the global default thinking level in Settings and, in the same commit, changed this label from 默认 to 模型默认 to disambiguate the two. #3606 reverses that naming decision deliberately; this issue only asks that the surrounding prose stop describing the old one.
#3606shortened the Chinese label for the per-chat thinking-level default from模型默认to默认, and it has been merged — the shorter label is the intended product behaviour.What is now out of date is the comment that describes the underlying contract.
apps/desktop/src/renderer/use-shell-chat-model.ts:111-114still reads:So the comment names the option
模型默认while the UI now shows默认. That mismatch is worth closing for a concrete reason rather than tidiness: the wording in that comment is what a reviewer reaches for when judging this label, and it will keep producing the same objection — that a bare默认cannot distinguish "restore the app default" from "override the app default and follow the model's own." Leaving the comment as-is means re-litigating the decision every time someone reads it.Suggested scope
Small and self-contained — a good first contribution.
use-shell-chat-model.ts:111-114so it describes the states in terms of the labels that actually ship. The three-state behaviour itself is unchanged and should stay:undefined= untouched picker, so the Settings default applies;null= an explicit per-chat choice that must override the configured default, otherwise the picker cannot undo it.defaultLevelinpackages/ui/src/conversation-copy.ts. It predates the Settings-wide default that#2430introduced and is the other stale description of this same control.No behaviour change and no test change is expected. If a reader concludes the contract should change rather than the comment, that is a separate discussion and worth raising here first.
Background
#2430(ede1f12f3) introduced the global default thinking level in Settings and, in the same commit, changed this label from默认to模型默认to disambiguate the two.#3606reverses that naming decision deliberately; this issue only asks that the surrounding prose stop describing the old one.