You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Features that look useful but are actually meaningless (in my opinion).
arg keep_parent_ref in provenance and provenance_multiple_parents
arpes.exceptions : pragmatically, it has not been used. And I don't think the own class for exception is good idea.
file loading by numbers alone, and without the location arg.
Currently, it is said that pyarpes tries to guess the location. However, there is no way to check whether the guess is correct or not, which may lead to the wrong analysis.
While load by number alone seems to be "elegant", but actually writing a function converting the appropriate file which depends on the situation from the number.
src/arpes/utilities/image.py
In certain special situations, this may be a meaningful function. However, as a practical matter, direct reading of image data is not likely to produce meaningful data (data that can be used in a paper).
src/arpes/optics.py
This should not be included in pyarpes, because it is not closely related to arpes analysis.
to_arrays in xarray_extensions.py
Too simple function. Only the burden of administration.
mean_annotation and sum_annotation
They are not one that we should bother to implement.
degrees_of_freedom and spectrum_degrees_of_freedom
Features that look useful but are actually meaningless (in my opinion).
arg
keep_parent_refinprovenanceandprovenance_multiple_parentsarpes.exceptions : pragmatically, it has not been used. And I don't think the own class for exception is good idea.
file loading by numbers alone, and without the location arg.
src/arpes/utilities/image.py
src/arpes/optics.py
to_arrays in xarray_extensions.py
mean_annotation and sum_annotation
degrees_of_freedom and spectrum_degrees_of_freedom
src/arpes/utilities/transform.py