Skip to content

allow_new_relation defaults still empty seeded sessions when forgotten #17

Description

@chouswei

Summary

Unknown @EDG relations abort the seed/add batch and roll back. session_open(..., allow_new_relation=False) is the default; forgetting the flag leaves rows=0 and is easy for LLM tool callers to miss.

Evidence

  • src/memnet_mcp/server.py session_open docs and allow_new_relation default; CHANGELOG notes seed batches rolling back on first unknown relation.
  • tests/test_mcp.py covers allow_new_relation and rollback behaviour.
  • Skills/docs repeatedly remind callers to pass allow_new_relation=true for novel/SysML seeds (mcp-memnet skill, SysML notes).

Impact

"Empty session" failures during bootstrap; agents proceed with a broken graph; hard to distinguish from map/seed typos without reading stderr carefully.

Suggested direction

Clearer MCP error when seed rolls back to zero rows; optional "register relations from seed EDG lines" mode; or fail session_open loudly with a dedicated @ERR code when seed is empty after intended seed_lines.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions