Skip to content

Chapter 8 keyvalue.proto DeleteRequest returns PutResponse #9

Description

@adamwoolhether

rpc Delete(DeleteRequest) returns (PutResponse);

Shouldn't the DeleteRequest return a DeleteResponse? Seems correct in the book, or is it ok either way because both responses are an empty struct?

However, when looking at the generated keyvalue_grpc.pb.gofile on page 236 Delete does return a *PutResponse, aligned with the repo., so is this a typo in the book?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions