This repository was archived by the owner on Jan 31, 2022. It is now read-only.
Description
Brief summary of issue
Right now calibrateArmDac.sh only dumps VFAT0 configuration to log file. This is a problem because:
This VFAT could be masked, and
The DAC values of each VFAT could be different (e.g. after DAC scans).
Types of issue
Expected Behavior
All VFAT settings are written to log file.
Current Behavior
Only VFAT0 is written to log file.
Possible Solution (for bugs)
This line should be executed inside of a loop over all VFATs:
echo " Writing configuration for CFG_THR_ARM_DAC=${armDacVal} to file"
echo " gem_reg.py -n ${CARDNAME} -e kw 'GEM_AMC.OH.OH${LINK} .GEB.VFAT0.CFG_' 2>&1 | tee -a scurveLog_ArmDac_${armDacVal} .txt"
echo " Configuration of All VFATs:" 2>&1 | tee -a scurveLog_ArmDac_${armDacVal} .txt
gem_reg.py -n ${CARDNAME} -e kw " GEM_AMC.OH.OH${LINK} .GEB.VFAT0.CFG_" 2>&1 | tee -a scurveLog_ArmDac_${armDacVal} .txt
sleep 1
Context (for feature requests)
For evaluating scan settings it is important to have all info in the log file.
Reactions are currently unavailable
Brief summary of issue
Right now
calibrateArmDac.shonly dumps VFAT0 configuration to log file. This is a problem because:Types of issue
Expected Behavior
All VFAT settings are written to log file.
Current Behavior
Only VFAT0 is written to log file.
Possible Solution (for bugs)
This line should be executed inside of a loop over all VFATs:
sw_utils/scripts/calibrateArmDac.sh
Lines 58 to 62 in 20707f0
Context (for feature requests)
For evaluating scan settings it is important to have all info in the log file.