From c5306eadbf32ae86bf4c4112baae7ccb3246901a Mon Sep 17 00:00:00 2001
From: Shinsuke Sugaya <shinsuke@apache.org>
Date: Wed, 9 Sep 2026 22:31:30 +0900
Subject: [PATCH] build!: leave the gcs: crawler client to the fess-lib-gcs
 plugin

crawler/client.xml no longer declares gcsClient or maps gcs:.* to it. GcsClient and the
gcs: URL handler stay in fess-crawler and still compile against the Google Cloud Storage
SDK; what changes is that nothing in this library names the class, so the SDK is no longer
needed to build the container.

Fess 15.9 stops shipping that SDK, which is around 17 MiB of jars for a protocol most
installations never crawl, and moves it to the fess-lib-gcs plugin. The plugin registers
the client through crawlerClientCreator, the way fess-crawler-playwright registers
playwrightClient, so installing it restores gcs: crawling.

Declaring the component here regardless of whether the SDK is present is not an option.
Lasta Di resolves the class named by a component while it parses the Di xml, not when the
component is first used, so an installation without the SDK does not start at all:

    DiXmlParseFailureException at /components[1]/include[19]
    Caused by: java.lang.NoClassDefFoundError: com/google/cloud/NoCredentials
    SEVERE: Exception starting filter [lastaPrepareFilter]
    SEVERE: Context [] startup failed due to previous errors

With the plugin installed it fails differently: both files declare gcsClient, the
component key becomes ambiguous, and the first crawl gets
TooManyRegistrationComponentException. Both were reproduced, the first on CI and the
second against a running Fess with a fake-gcs-server bucket.

Consumers of this library that relied on the gcs: mapping keep GcsClient itself and can
register it in their own container.
---
 .../src/main/resources/crawler/client.xml          | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/fess-crawler-lasta/src/main/resources/crawler/client.xml b/fess-crawler-lasta/src/main/resources/crawler/client.xml
index cd6442051..405ad7d6a 100644
--- a/fess-crawler-lasta/src/main/resources/crawler/client.xml
+++ b/fess-crawler-lasta/src/main/resources/crawler/client.xml
@@ -56,10 +56,12 @@
 		<property name="charset">"UTF-8"</property>
 	</component>
 
-	<component name="gcsClient"
-		class="org.codelibs.fess.crawler.client.gcs.GcsClient" instance="prototype">
-		<property name="charset">"UTF-8"</property>
-	</component>
+	<!-- gcs: has no client registered here. GcsClient stays in this library, but the Google Cloud
+	     Storage SDK it needs is 17 MiB that most installations never crawl, so Fess ships it in the
+	     fess-lib-gcs plugin, which registers the client through crawlerClientCreator the way
+	     fess-crawler-playwright registers playwrightClient. Registering it here instead would make
+	     every CrawlerClientFactory fail to build wherever the SDK is absent, because the component
+	     reference below is resolved when the factory is created. -->
 
 	<component name="crawlerClientCreator"
 		class="org.codelibs.fess.crawler.client.CrawlerClientCreator">
@@ -95,10 +97,6 @@
 			<arg>"s3:.*"</arg>
 			<arg>s3Client</arg>
 		</postConstruct>
-		<postConstruct name="addClient">
-			<arg>"gcs:.*"</arg>
-			<arg>gcsClient</arg>
-		</postConstruct>
 	</component>
 
 </components>