fix(tests): keep self-exited stall runs unretried with code intact

A stall-declared run that exits on its own is never a stall: SIGTERM death reads as null or 143, any other code is the child's own and must survive unretried.

Author: TheGreatAxios

scripts/test-parallel.test.ts

@@ -92,6 +92,26 @@ describe("runWithWatchdog", () => {
     expect(stalls).toEqual([[1, 3]]);
   });
 
+  test("a stall-declared run that exits on its own keeps its code and is not retried", async () => {
+    // Ignores SIGTERM so the watchdog's stall kill cannot take it out, then
+    // exits 3 on its own well after the stall window (so the stall is
+    // declared first). The real code must survive and the run must not retry.
+    const result = await runWithWatchdog({
+      command: process.execPath,
+      args: [
+        "-e",
+        'process.on("SIGTERM", () => {}); setTimeout(() => process.exit(3), 4_000);',
+      ],
+      stallMs: TEST_STALL_MS,
+      onStall: () => {
+        throw new Error("must not retry a run that exited on its own");
+      },
+    });
+    expect(result.exitCode).toBe(3);
+    expect(result.stalled).toBe(false);
+    expect(result.attempts).toBe(1);
+  });
+
   test("gives up after the final attempt with exit code 1", async () => {
     const stalls: [number, number][] = [];
     const result = await runWithWatchdog({

scripts/test-parallel.ts

@@ -126,9 +126,12 @@ async function runAttempt(
   exited = true;
   clearInterval(watchdog);
   await Promise.allSettled(pumps);
-  // null means killed by a signal; the stalled flag says who did it.
-  const exitCode = raw === null ? (stalled ? STALL_CODE : 1) : raw;
-  return { exitCode, stalled };
+  // A SIGTERM kill surfaces as null (died by signal) or 143 (Bun's SIGTERM
+  // exit); any other code means the child exited on its own and keeps its
+  // code unretried, even if the watchdog already fired.
+  const killedByWatchdog = stalled && (raw === null || raw === 143);
+  const exitCode = killedByWatchdog ? STALL_CODE : (raw ?? 1);
+  return { exitCode, stalled: killedByWatchdog };
 }
 
 export async function runWithWatchdog(