Skip to content

Commit a46d7c5

Browse files
committed
fix: scope warden to the on-demand skill surface
Warden's test pinned the pre-skill review surface; skill tools now ride REVIEW_TOOLS via READ_TOOLS, scoped at mount to optionalSkills. Update the expectation and the prompt line to match critic.
1 parent 55a893b commit a46d7c5

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

src/agent/directors/warden/package.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,10 @@ describe("wardenPackage", () => {
8282
test("tools.allow is review surface with product writes", () => {
8383
const allow = wardenPackage.tools?.allow ?? [];
8484
expect(allow).toContain("read_file");
85-
expect(allow).not.toContain("use_skill");
85+
// Skill tools ride REVIEW_TOOLS via READ_TOOLS (scoped at mount to
86+
// optionalSkills) so warden loads its skills on demand like critic.
87+
expect(allow).toContain("skill_search");
88+
expect(allow).toContain("use_skill");
8689
expect(allow).toContain("write_file");
8790
expect(allow).toContain("edit_file");
8891
expect(allow).toContain("delete_file");

src/agent/directors/warden/package.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Evidence rules:
4242
- Call out gaps: what you did not cover so the parent does not assume closed.
4343
- Recommend permanent tests the suite should keep (name the scenario; do not implement them here — route to testsmith/builder).
4444
45-
Before substantial review work: follow style, philosophy, native-integration, and idiot-proof (baked; use_skill is not mounted on workers). Read the code under review.
45+
Before substantial review work: follow style, philosophy, native-integration, and idiot-proof — load each with skill_search + use_skill only when the brief needs it. Read the code under review.
4646
4747
OUT OF LANE → refuse or reclassify under Blockers:
4848
- implementing fixes (route to builder)

0 commit comments

Comments
 (0)