Skip to content

Check root CA certificates into the repo instead of downloading at build time #2079

Description

@lbussell

Currently, the ImageBuilder Dockerfile downloads root CA certificates from microsoft.com/pkiops at build time:

# download root CA certificates for signature verification
WORKDIR /
RUN mkdir -p notation-trust/certs/test notation-trust/certs/supplychain \
&& curl -fSL --output notation-trust/certs/test/root-ca.crt \
"https://www.microsoft.com/pkiops/certs/Microsoft%20RSA%20Testing%20Root%20Certificate%20Authority%202019.crt" \
&& curl -fSL --output notation-trust/certs/supplychain/root-ca.crt \
"https://www.microsoft.com/pkiops/certs/Microsoft%20Supply%20Chain%20RSA%20Root%20CA%202022.crt"

Instead, we should check the certificate files into the repo and COPY them in the Dockerfile. The certificates are public root CAs that change very infrequently, so there is no freshness benefit to downloading them on every build.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

  • Status
    Current Release

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions