From 69653e7ab3c34a5264aa383e0d5739cf04a75443 Mon Sep 17 00:00:00 2001 From: Patrick Ziegler Date: Wed, 16 Sep 2026 06:30:55 +0200 Subject: [PATCH] [GEF] MoveHandle should use GEF DragEditPartsTracker directly --- .../eclipse/wb/gef/graphical/handles/MoveHandle.java | 10 ---------- .../generic/AbstractContainerRequestValidator.java | 4 ++++ 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/graphical/handles/MoveHandle.java b/org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/graphical/handles/MoveHandle.java index 226eb7995..72fa158f0 100644 --- a/org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/graphical/handles/MoveHandle.java +++ b/org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/graphical/handles/MoveHandle.java @@ -12,10 +12,7 @@ *******************************************************************************/ package org.eclipse.wb.gef.graphical.handles; -import org.eclipse.wb.gef.core.tools.DragEditPartTracker; - import org.eclipse.draw2d.Locator; -import org.eclipse.gef.DragTracker; import org.eclipse.gef.EditPart; import org.eclipse.gef.GraphicalEditPart; import org.eclipse.gef.handles.MoveHandleLocator; @@ -47,11 +44,4 @@ public MoveHandle(GraphicalEditPart owner) { public MoveHandle(GraphicalEditPart owner, Locator locator) { super(owner, locator); } - - @Override - protected DragTracker createDragTracker() { - DragEditPartTracker tracker = new DragEditPartTracker(getOwner()); - tracker.setDefaultCursor(getCursor()); - return tracker; - } } \ No newline at end of file diff --git a/org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/policy/layout/generic/AbstractContainerRequestValidator.java b/org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/policy/layout/generic/AbstractContainerRequestValidator.java index 932bb531f..4bf262ff7 100644 --- a/org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/policy/layout/generic/AbstractContainerRequestValidator.java +++ b/org.eclipse.wb.core/src/org/eclipse/wb/internal/core/gef/policy/layout/generic/AbstractContainerRequestValidator.java @@ -84,6 +84,10 @@ public boolean validateAddRequest(EditPart host, ChangeBoundsRequest request) { // //////////////////////////////////////////////////////////////////////////// private boolean validateComponents(ChangeBoundsRequest request) { + // Might not be set when called from within "createOperationSet()" + if (request.getEditParts() == null) { + return true; + } for (EditPart editPart : request.getEditParts()) { Object object = editPart.getModel(); if (!m_container.validateComponent(object)) {