Skip to content

silent error with wide images #33

Description

@dgutson

git-diff-image silently fails with wide images.
By doing this change:

diff --git a/diff-image b/diff-image
index 1da14a4..0dbcfdb 100755
--- a/diff-image
+++ b/diff-image
@@ -195,7 +195,7 @@ density_flag=
 do_compare()
 {
     compare $density_flag $color_flag $fuzz_flag $backgroundcolor_flag "$f1" "$f2" png:- | \
-        montage $density_flag -geometry +4+4 $backgroundcolor_flag "$f1" - "$f2" png:- >"$destfile" 2>/dev/null || true
+        montage $density_flag -geometry +4+4 $backgroundcolor_flag "$f1" - "$f2" png:- >"$destfile"
 }

 if which xdg-open > /dev/null

compare throws this error:

montage-im6.q16: width or height exceeds limit `png:-' @ error/cache.c/OpenPixelCache/3909.

Please allow larger images, and consider some sort of error reporting.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions