Skip to content

hash_combine results in hash collision #902

Description

@suranap

The current hash_combine caused a ShardingID collision when I ran with 14 nodes on Perlmutter. It looks like the first version that was in Boost. Here's some info on Boost's recent implementation.

These machine views produced the same hash of 1804451222.

MachineView<0=[44:46:1]>
MachineView<0=[41:97:1]>

I updated my branch to use the 64bit version. It might be better to copy their whole implementation, which dispatches to 32 or 64 bits depending on size_t.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions