Surfaced by Copilot review on #38, deferred there because it is #36's design and #38 was a re-land.
skills/overnight/SKILL.md Phase 1 defines a bare item as one with no artifact — a plain prose bullet. Phase 3 then says, unconditionally:
For each answer the user gives, write it back into the item's source artifact as a dated resolution […] An answer that lives only in this conversation is lost the moment the session ends.
For a bare item there is no such artifact, so its answers and recorded assumptions have nowhere to go — breaking exactly the durable handoff the later kickoff invocation depends on, and the one the sentence itself argues for.
Two related edges from the same review:
- Ticket-backed items. The project-specifics section says this skill only reads tracker tickets (
deliver owns status). If a ticket is the source artifact, Phase 3 either writes to the tracker (contradicting read-only) or drops the resolution.
- Write timing. Phase 3's writes happen before Phase 4 creates any per-item branch, so repo-backed spec/brief edits for all items land in the current checkout.
kickoff can then sweep unrelated items' edits into the first PR, and into every stack base below it.
Fix: define one explicit writable handoff artifact per item — created for bare items before the answers are recorded — and defer repo-backed writes until that item's branch exists.
Note: there is also a confidentiality angle. A direct write to an external tracker happens outside deliver's Phase 2b gate, so a client detail in an answer could reach an external system before anything scans it. Worth settling alongside the read-only question.
Surfaced by Copilot review on #38, deferred there because it is #36's design and #38 was a re-land.
skills/overnight/SKILL.mdPhase 1 defines a bare item as one with no artifact — a plain prose bullet. Phase 3 then says, unconditionally:For a bare item there is no such artifact, so its answers and recorded assumptions have nowhere to go — breaking exactly the durable handoff the later
kickoffinvocation depends on, and the one the sentence itself argues for.Two related edges from the same review:
deliverowns status). If a ticket is the source artifact, Phase 3 either writes to the tracker (contradicting read-only) or drops the resolution.kickoffcan then sweep unrelated items' edits into the first PR, and into every stack base below it.Fix: define one explicit writable handoff artifact per item — created for bare items before the answers are recorded — and defer repo-backed writes until that item's branch exists.
Note: there is also a confidentiality angle. A direct write to an external tracker happens outside
deliver's Phase 2b gate, so a client detail in an answer could reach an external system before anything scans it. Worth settling alongside the read-only question.