Skip to content

Commit b4608eb

Browse files
committed
fix(io): update Reader.read to respect Liskov Substitution Principle
flagged by ty
1 parent 2c42d19 commit b4608eb

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

src/java/io/__init__.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
from java.lang import (
3737
Appendable,
3838
AutoCloseable,
39+
CharBuffer,
3940
CharSequence,
4041
Exception,
4142
Object,
@@ -334,8 +335,8 @@ def nullReader():
334335
# type: () -> Reader
335336
pass
336337

337-
def read(self, *args):
338-
# type: (*Any) -> int
338+
def read(self, cb):
339+
# type: (CharBuffer) -> int
339340
pass
340341

341342
def ready(self):

stubs/stubs/java/io/__init__.pyi

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ from typing import Any, Optional, Union
33
from java.lang import (
44
Appendable,
55
AutoCloseable,
6+
CharBuffer,
67
CharSequence,
78
Exception,
89
Object,
@@ -112,7 +113,7 @@ class Reader(Object, Readable, Closeable):
112113
def markSupported(self) -> bool: ...
113114
@staticmethod
114115
def nullReader() -> Reader: ...
115-
def read(self, *args: Any) -> int: ...
116+
def read(self, cb: CharBuffer) -> int: ...
116117
def ready(self) -> bool: ...
117118
def reset(self) -> None: ...
118119
def skip(self, n: long) -> long: ...

0 commit comments

Comments
 (0)