Skip to content

targeted feedback: extend pin targets to flow edges, vega marks, mermaid, calltree #225

Description

@ivanmkc

v1 pin targets: pane, flow-node, component (props.id), checklist-item, markdown heading. Explicit non-goals deferred from the spec:

  • flow edges — thin hit targets; verify React Flow edge DOM carries a resolvable data-id before enabling.
  • vega-lite marks — no stable ids; would need scenegraph hit → encoding field/value capture.
  • mermaid elements — rendered SVG has generated ids only.
  • calltree nodes — tree rows have labels, not ids; a path-of-labels id scheme would work.

Everything else (wire format, composer, CLI, skill docs) is target-kind-agnostic — each of these is mostly a resolver branch in comment-target.ts plus a TARGET_KINDS entry server-side.

Context: docs/superpowers/specs/2026-07-03-targeted-feedback-design.md (non-goals), PR #220.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions