FR: improving word matching logic

[levinion]

I really like the idea of this plugin, but there are still some flaws in word matching currently.

It would be even better if we could support:

• Matching from the cursor position to the end of the word, which should be a more ideal default behavior.

• Matching based on visual mode, which allows replacing sequences of more than one word or a certain part within a word.

[leblocks]

Let me think about it :) why do you think that first one (matching from the cursor position to the end of the word) is a better behaviour? Can you provide some examples why it may be a better approach?

[levinion]

Take vim.diagnostic.goto_prev for example.

I usually just want to change a specific part, like prev, without touching the vim.diagnostic.goto_ prefix. Right now, if the plugin tries to match the whole word, it might fail to find what I'm looking for.

But if I put my cursor on the p, and it matches from there to the end, I can easily target just prev. This makes it way more flexible for method chains or long names.

[leblocks]

Thanks, I'll try to provide this functionality.

[leblocks]

@levinion take a look at this branch refactor_and_add_replacer_matching_from_cursor_to_the_end_of_the_word
I hope it provides your expected end of word matching behaviour

#5

[levinion]

Thanks. I’d like to check it tomorrow!

[levinion]

it seems to work as expected.

• Matching based on visual mode, which allows replacing sequences of more than one word or a certain part within a word.

And would you consider to implement this feature? It would add a lot of flexibility to the plugin.

[leblocks]

I'll think about it, you mena VISUAL mode, not VISUAL-BLOCK, right?

[levinion]

Yeah.

[leblocks]

I've created a separate issue for that #7