Artifacts: Discrepancy between single- and multi-targeting scenarios

[KirillOsenkov]

This PR #227 added more knobs to the single-targeting branch, but not the multi-targeting branch.

So this:

MSBuildSdks/src/Artifacts/build/Microsoft.Build.Artifacts.targets

Lines 36 to 44 in 28c42cc

	<Artifact Include="$(DefaultArtifactsSource)"
	DestinationFolder="$(ArtifactsPath)"
	FileMatch="$([MSBuild]::ValueOrDefault($(DefaultArtifactsFileMatch), '*exe *dll *exe.config *nupkg'))"
	FileExclude="$(DefaultArtifactsFileExclude)"
	DirExclude="$([MSBuild]::ValueOrDefault($(DefaultArtifactsDirExclude), 'ref'))"
	IsRecursive="$(DefaultArtifactsIsRecursive)"
	VerifyExists="$(DefaultArtifactsVerifyExists)"
	AlwaysCopy="$(DefaultArtifactsAlwaysCopy)"
	OnlyNewer="$(DefaultArtifactsOnlyNewer)" />

Is richer than this:

MSBuildSdks/src/Artifacts/buildMultiTargeting/Microsoft.Build.Artifacts.targets

Lines 31 to 33 in 28c42cc

	<Artifact Include="$([MSBuild]::ValueOrDefault($(DefaultArtifactsSource), $(OutputPath)))"
	DestinationFolder="$(ArtifactsPath)"
	FileMatch="$([MSBuild]::ValueOrDefault($(DefaultArtifactsFileMatch), '*exe *dll *exe.config *nupkg'))" />

Should we perhaps unify?

Jeff Kluge (@jeffkl)

[jeffkl]

Yeah I'm not sure if it makes more sense to copy/paste or move the better one to https://github.com/microsoft/MSBuildSdks/blob/28c42cc282731aa69920a1f0582cfaba814315d2/src/Artifacts/build/Microsoft.Build.Artifacts.Common.targets ?

[KirillOsenkov]

either one!