onecx-document-svc
- https://github.com/onecx/onecx-document-svc/blob/main/src/main/openapi/onecx-document-internal.yaml
Especially on the API, there are multiple bad practices.
some examples:
- POST for searching is named "getDocumentsByCrtieria" => should be search not get (done)
- searchCriterias are not mandatory but they should be. (done)
- a lot of unused schemes in the API which can be removed and more. (done)
- https://github.com/onecx/onecx-document-svc/blob/main/src/main/java/org/tkit/onecx/document/rs/internal/controllers/DocumentController.java#L80-L87
we can just get rid of the startDate and endDate criterias because they are not used., and additionally createBy (done)
- Restcontroller methods shouldnt be Transactional, fix this as well please (done)
- Doubled api dependency in POM (done)
onecx-document-bff
- adjusted bff api and controllers for changes in onecx-document-internal.yaml - adjusted bff for new API from Backend - search by createria, post for deleteBulkDocuments
- checking that
/document/search/show-all-documents is used in src/app/shared/generated/api/documentController.service.ts by UI
- cleaned api from unused schemas
onecx-document-ui
- adjusted functionality with new api definision
event-mgmt-svc (work duplicated with another story, so finally haven't been merged.)
(https://gitlab.com/1000kit/apps/event-mgmt/event-management/-/blob/master/src/main/java/org/tkit/eventmanagement/tools/EventToolsV1.java?ref_type=heads)
we addded MCP server here (EventToolsV1.java) we need more tools like AttendeeToolsV1.java etc.
So basically we want to have tools to cover all functionalities of internal controllers
onecx-document-svc
Especially on the API, there are multiple bad practices.
some examples:
we can just get rid of the startDate and endDate criterias because they are not used., and additionally createBy (done)
onecx-document-bff
/document/search/show-all-documentsis used in src/app/shared/generated/api/documentController.service.ts by UIonecx-document-ui
event-mgmt-svc (work duplicated with another story, so finally haven't been merged.)
(https://gitlab.com/1000kit/apps/event-mgmt/event-management/-/blob/master/src/main/java/org/tkit/eventmanagement/tools/EventToolsV1.java?ref_type=heads)
we addded MCP server here (EventToolsV1.java) we need more tools like AttendeeToolsV1.java etc.
So basically we want to have tools to cover all functionalities of internal controllers