Skip to content

Very large values in numerical columns can cause a crash due to overflow #7

Description

@Schaechtle

This line can crash with an overflow error for very large values of x becasue Clojure doesn't automatically upgrade Ints to BigInts. This happend with the Gapminder dataset and is reproducible in the Clojure repl:

$ clojure
Clojure 1.11.1
user=> (def a 12756500000000)
#'user/a
user=> (* a a)
Execution error (ArithmeticException) at java.lang.Math/multiplyExact (Math.java:892).
long overflow

The value 12756500000000 is the problematic cell value in the Gapminder dataset. It's unclear whether this problem is common.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions