Skip to content

subscript assignment should not be split into multiple lines #407

Description

@maxnotarangelo

When you assign a value to an element of an array or a hash, it looks pretty weird if the assignment part is split into three lines instead of one.

Original:

some_hash = { name: "my hash" }
some_array = ["hello", "goodbye"]

if some_condition?
  some_hash[:description] = "a long description that will be too long for a single line"
  some_array[0] = "a very long greeting that will be much too long for a single line"
end

Formatted:

some_hash = { name: "my hash" }
some_array = %w[hello goodbye]

if some_condition?
  some_hash[
    :description
  ] = "a long description that will be too long for a single line"
  some_array[
    0
  ] = "a very long greeting that will be much too long for a single line"
end

Preferred formatting:

some_hash = { name: "my hash" }
some_array = %w[hello goodbye]

if some_condition?
  some_hash[:description] =
    "a long description that will be too long for a single line"
  some_array[0] =
    "a very long greeting that will be much too long for a single line"
end

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions