Fix instance of XFAIL when running Go implementation

Author: simonhammes

README.md

@@ -99,7 +99,7 @@ cd version-compare
 export SEATABLE_IMAGE=seatable/seatable-enterprise
 export SEATABLE_VERSION=6.0.10
 
-# seatable/dtable-server-go (default) or seatable/dtable-server-js
+# seatable/dtable-server-go or seatable/dtable-server-js
 export DTABLE_SERVER_IMAGE=seatable/dtable-server-go
 export DTABLE_SERVER_VERSION=7.0.7-testing
 

tests/conftest.py

@@ -14,6 +14,9 @@
 from typing import Generator
 
 
+USES_GO_DTABLE_SERVER = os.environ.get('DTABLE_SERVER_IMAGE', '').endswith('dtable-server-go')
+
+
 def pytest_configure(config):
     config.addinivalue_line(
         'markers',

tests/test_columns.py

@@ -1,5 +1,5 @@
 import pytest
-from conftest import Base, base_operations_schema
+from conftest import Base, base_operations_schema, USES_GO_DTABLE_SERVER
 from schemathesis import Case
 from syrupy.assertion import SnapshotAssertion
 from syrupy.matchers import path_type
@@ -399,6 +399,7 @@ def test_insertColumn_duplicate_name_returns_400(base: Base):
 
 
 @pytest.mark.xfail(
+    not USES_GO_DTABLE_SERVER,
     reason="insertColumn returns the plain-text body 'Column ColA exists.' with an "
            "application/json content-type on a duplicate-column 400 (not valid JSON)",
 )

version-compare/docker-compose.yml

@@ -40,7 +40,7 @@ services:
       - backend
 
   dtable-server:
-    image: ${DTABLE_SERVER_IMAGE:-seatable/dtable-server-go}:${DTABLE_SERVER_VERSION:?Variable is not set}
+    image: ${DTABLE_SERVER_IMAGE:?Variable is not set}:${DTABLE_SERVER_VERSION:?Variable is not set}
     container_name: dtable-server
     restart: unless-stopped
     environment: