Skip to content

bump amqp.node version to 0.4.4 (Node 4.x) #114

Description

@jcollum

I tried to fork and update but one of the tests is failing:

08:01 ~/work/rabbit.js  (master)$ ./node_modules/mocha/bin/mocha --ui exports test -g 'closeConne'

Using connection parameters:
"amqp://localhost"

  1) closeConnectionWithoutSocket
Potentially unhandled rejection [1] IllegalOperationError: Connection closed (Closed by client)
    at Connection.close (/Users/collumj/work/rabbit.js/node_modules/amqplib/lib/connection.js:405:14)
    at ChannelModel.CM.close (/Users/collumj/work/rabbit.js/node_modules/amqplib/lib/channel_model.js:33:19)
    at /Users/collumj/work/rabbit.js/lib/sockets.js:81:7
    at tryCatchReject (/Users/collumj/work/rabbit.js/node_modules/amqplib/node_modules/when/lib/makePromise.js:840:30)
    at runContinuation1 (/Users/collumj/work/rabbit.js/node_modules/amqplib/node_modules/when/lib/makePromise.js:799:4)
    at Fulfilled.when (/Users/collumj/work/rabbit.js/node_modules/amqplib/node_modules/when/lib/makePromise.js:590:4)
    at ContinuationTask.run (/Users/collumj/work/rabbit.js/node_modules/amqplib/node_modules/when/lib/makePromise.js:697:24)
    at Scheduler._drain (/Users/collumj/work/rabbit.js/node_modules/amqplib/node_modules/when/lib/Scheduler.js:62:19)
    at Scheduler.drain (/Users/collumj/work/rabbit.js/node_modules/amqplib/node_modules/when/lib/Scheduler.js:27:9)
    at doNTCallback0 (node.js:407:9)
    at process._tickCallback (node.js:336:13)

  0 passing (2m)
  1 failing

  1)  closeConnectionWithoutSocket:
     Error: done() invoked with non-Error: Closed by client
      at Context.closeAndDone (test/tests.js:50:15)
      at Connection.C.toClosed (node_modules/amqplib/lib/connection.js:411:8)
      at Connection.accept (node_modules/amqplib/lib/connection.js:378:12)
      at Socket.go (node_modules/amqplib/lib/connection.js:474:48)
      at emitReadable_ (_stream_readable.js:411:10)
      at emitReadable (_stream_readable.js:405:7)
      at readableAddChunk (_stream_readable.js:157:11)
      at Socket.Readable.push (_stream_readable.js:110:10)
      at TCP.onread (net.js:523:20)

I couldn't make any sense out of that error message. Anyway, I thought you'd like to know that only one of your tests is failing when you bump to amqplib 0.4.x and node 4.0.x. If you'd like me to submit a pull req even though the test is failing let me know.

https://github.com/jcollum/rabbit.js

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions