Skip to content

Remove data related props from the component's props #242

Description

@dariocravero

When we have a view that uses data, some of the args land on the props even though they shouldn't because they're local.
They're:

isValid,
isInvalid,
isSubmitting,
onSubmit,
onChange

Not a blocker at all but it'd be nice if eventually we could not render them into the file.

Eg:

Auth View
is together
  Text
  letterSpacing 1.5
  data stuff
  format stuff
  text <value
  Text
  data stuff
  format tey
  validate test
  isVVVV <isValid
  isInvaliddd <isInvalid
  text <value
  isSubmitting <
  onSubttttt <onSubmit
  onClick <onSubmit
  onChange <onChange

Outputs:

export default function Auth({
  children,
  'data-testid': dataTestid,
  'data-view-path': dataViewPath,
  viewPath= "/App/Auth",
isValid,
isInvalid,
isSubmitting,
onSubmit,
onChange
}) {

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions