fix: Gittea write config to XDG_CONFIG_HOME when set#620
Open
rr3khan wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
On macOS with
$XDG_CONFIG_HOMEexported,op plugin init teawrites tea's config to a path tea never reads, so everyteacommand fails withError: no available login.The plugin resolves the config path with
os.UserConfigDir(), which ignores$XDG_CONFIG_HOMEon darwin, while tea resolves it throughadrg/xdg, which prefers$XDG_CONFIG_HOMEon every platform. When the variable is set (common for users syncing dotfiles across Linux and macOS), the two diverge: the plugin writes to~/Library/Application Support/tea/config.ymlwhile tea reads from$XDG_CONFIG_HOME/tea/config.yml.ConfigPath()now checks$XDG_CONFIG_HOMEfirst and falls back toos.UserConfigDir(), matching tea's own resolution order. Added tests covering both branches.Type of change
Related Issue(s)
How To Test
Without
$XDG_CONFIG_HOMEset, behavior is unchanged (os.UserConfigDir()fallback).go test ./plugins/gitea/...andmake gitea/validatepass.Changelog
The Gitea plugin now writes tea's configuration to the location tea reads when
XDG_CONFIG_HOMEis set.