build: pin Rust toolchain version via rust-toolchain.toml - #126
Conversation
markdownlint-cli2 is an npm-backend mise tool that requires node@26 as a configured install dependency, but check-markdown.yml only listed markdownlint-cli2 in install_args, so node was never installed and the mise install step failed.
…node-dependency fix: add node install dependency for markdownlint-cli2 in CI
Rust had no pinned version, so a stale local rustup `stable` could drift below what dependencies require (e.g. serial_test needing a newer rustc than installed), breaking `mise run rs-check` locally. Pinning also lets `check-rust.yml` drop its own `components` input, since setup-rust-toolchain now picks them up from the toolchain file.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe repository pins Rust to version 1.98.0 with ChangesToolchain and CI setup
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR pins the Rust toolchain and aligns the related checks with that pin. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches✨ Simplify code
Comment |
Checklist
mainSummary
Closes #125
Reason for change
Rust had no pinned version in this repo (not managed via mise, and no
rust-toolchain.toml), so a stale local rustupstablechannel could drift below what dependencies require. This brokemise run rs-checklocally with:Changes
rust-toolchain.tomlpinningchannel = "1.98.0"withcomponents = ["rustfmt", "clippy"]components: rustfmt, clippyinput fromcheck-rust.yml'ssetup-rust-toolchainstep, since it now picks up components from the toolchain fileNotes
None