fix: bump black to 26.3.1 (arbitrary file write via cache filename) - #48
Open
ajaiswal-qsi-strand wants to merge 1 commit into
Open
fix: bump black to 26.3.1 (arbitrary file write via cache filename)#48ajaiswal-qsi-strand wants to merge 1 commit into
ajaiswal-qsi-strand wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: bump black to 26.3.1 (arbitrary file write via cache filename)
Summary
Bumps the pinned
blackfrom25.1.0to26.3.1to address a security vulnerability, and releases as2.0.1.Why
blackversions< 26.3.1are vulnerable to arbitrary file writes from unsanitized user input in the cache file name (GHSA / Dependabot high-severity advisory). Sincefourmatpinsblackwith an exact version (black==25.1.0), downstream consumers cannot upgrade black without updating fourmat.Changes
setup.py:black==25.1.0→black==26.3.1setup.py:version2.0.0→2.0.1Testing
fourmat check— exit 0 (self-lint passes with black 26.3.1)pytest test/— 5 passedblack --version→ 26.3.1Note: running
fourmat checkon Python 3.10 emits black's standard AST safety-check warning (config targets py312); this is environment-related and non-fatal (exit 0). CI's tox matrix runs py310/311/312 separately.