fix(tui): remove extra spacing between message area and composer - #178
Merged
Conversation
Use exact Length constraints with actual viewport line counts instead of Constraint::Min(1) which forced an extra blank row in the history area. Remove the +2 padding in desired_height and the saturating_sub(1) clamping in chat_layout_areas so the viewport height is always exactly the sum of content heights with no leftover blank rows. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the 3-line gap between the message output area and the composer (dialog box) in the TUI.
Root Cause
Three issues in
crates/tui/src/chatwidget/render.rs:desired_heightadded +2 extra rows — the viewport was always 2 rows taller than the actual content sumsaturating_sub(1)— shaved 1 row off the bottom pane even when the viewport was exactly sizedConstraint::Min(1)for history arena — forced at least 1 empty row even with no messages, because this ratatui fork guarantees Min constraints their minimumChanges
Constraint::Length(history_height)computed from actual viewport line count instead ofConstraint::Min(1)+ 2padding indesired_heightsaturating_sub(1)clamping on bottom heightThe three changes work together to ensure viewport height exactly equals the sum of content heights with no leftover blank rows.
🤖 Generated with Claude Code