Fix: Add XLSX signature to MicrosoftOffice365Document (fixes #59)#60
Open
AndrewNowosad wants to merge 1 commit into
Open
Fix: Add XLSX signature to MicrosoftOffice365Document (fixes #59)#60AndrewNowosad wants to merge 1 commit into
AndrewNowosad wants to merge 1 commit into
Conversation
Add the signature 50 4B 03 04 14 00 06 08 08 00 to the list of recognized Office 365 document signatures. This signature is used by some XLSX files (e.g. saved by non-Microsoft editors) and should be recognized as XLSX instead of generic ZIP files. Fixes AJMitev#59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a missing XLSX file signature to the
MicrosoftOffice365Documentclass.Problem
XLSX files with the signature
50 4B 03 04 14 00 06 08 08 00were being incorrectly identified as ZIP files instead of XLSX files.Solution
Added the signature
0x50, 0x4B, 0x03, 0x04, 0x14, 0x00, 0x06, 0x08, 0x08, 0x00to the list of recognized Office 365 document signatures in theMicrosoftOffice365Documentclass. Added a test fixture (test-issue-59.xlsx, a small synthetic file built to reproduce exactly this local file header) and a corresponding test case.Fixes
Fixes #59