Skip to content

Refactor handle_inter_mode and separate single and compound mode searches #5239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kslu-aom wants to merge 6 commits into
base: av2-enc
Choose a base branch
from
+554 −386
Draft

Refactor handle_inter_mode and separate single and compound mode searches #5239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
140f941
Combine ref_mv_idx loops in handle_inter_mode into a single flat loop
kslu-aom Jul 22, 2026
b12a0d7
Clean up the refactoring
kslu-aom Aug 10, 2026
4ef4577
himrefKc: more minor cleanups
kslu-aom Aug 10, 2026
8c0b607
Fix CI errors and add comments
kslu-aom Aug 11, 2026
546cef6
Address issues and cleanups in the comments
kslu-aom Aug 12, 2026
3c2b1d8
Add a TODO for future cleanups
kslu-aom Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions av2/common/reconinter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4030,12 +4030,10 @@ void set_most_probable_mv_precision(const AV2_COMMON *const cm,
#endif
}
void set_precision_set(const AV2_COMMON *const cm, MACROBLOCKD *const xd,
MB_MODE_INFO *mbmi, const BLOCK_SIZE bsize,
int *ref_mv_idx) {
MB_MODE_INFO *mbmi, const BLOCK_SIZE bsize) {
(void)bsize;
(void)cm;
(void)xd;
(void)ref_mv_idx;
mbmi->mb_precision_set =
(mbmi->max_mv_precision < MV_PRECISION_HALF_PEL)
? 0
Expand Down
3 changes: 1 addition & 2 deletions av2/common/reconinter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1250,8 +1250,7 @@ void set_default_precision_set(const AV2_COMMON *const cm, MB_MODE_INFO *mbmi,

// Set the precision set of the block. Currently, the value is 0.
void set_precision_set(const AV2_COMMON *const cm, MACROBLOCKD *const xd,
MB_MODE_INFO *mbmi, const BLOCK_SIZE bsize,
int *ref_mv_idx);
MB_MODE_INFO *mbmi, const BLOCK_SIZE bsize);
// Get the index of the precision
// this index is signalled when precision is not same as the most probable
// precision
Expand Down
2 changes: 1 addition & 1 deletion av2/decoder/decodemv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2799,7 +2799,7 @@ static void read_inter_block_mode_info(AV2Decoder *const pbi,
ec_ctx, mbmi, r);
set_mv_precision(mbmi, mbmi->max_mv_precision);
if (is_pb_mv_precision_active(cm, mbmi, bsize)) {
set_precision_set(cm, xd, mbmi, bsize, mbmi->ref_mv_idx);
set_precision_set(cm, xd, mbmi, bsize);
set_most_probable_mv_precision(cm, mbmi, bsize);
mbmi->pb_mv_precision = av2_read_pb_mv_precision(cm, xd, r);
}
Expand Down
Loading
Loading