Add audio sink renaming to LinkKit - #77
Merged
Merged
Conversation
Contributor
|
Thank you! |
Contributor
Author
You're welcome! Thanks for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinkKit accepts a channel name when creating an audio sink, but has no public API to change it. Recreating the sink to rename it changes the channel ID, so receiving apps have to select the stream again.
Add
ABLLinkAudioSinkSetName, forwarding to the existingLinkAudioSink::setName. This preserves the channel ID and existing receiver subscriptions. The header documents the name limit and non-thread-safe, non-realtime-safe contract.Verified with Xcode 26.3 against the Link commit pinned by LinkKit CI,
be64e5d1fe0cd01dea016ae31c2cefaddc0ce558:No application engine or changes to the Link dependency were needed for the implementation. Verification used a temporary standalone probe; no new test target is included.