Fix mutable default in configclass fallback (no-IsaacLab path) - #10
Merged
kouroshD merged 1 commit intoAug 28, 2026
Merged
Conversation
kouroshD
approved these changes
Aug 28, 2026
Collaborator
|
Thanks, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
matterix_smis supposed to work without Isaac Lab installed, using the fallbackconfigclassin_compat.py. Right now it crashes on import because two fields use a mutable default (= []) instead offield(default_factory=list):primitive_actions/semantic_action.pyprimitive_actions/wait.pyThe dataclasses module doesn't allow mutable defaults (Isaac Lab's own
configclassapparently handles this, but the fallback doesn't). Fixed both to usedefault_factory, matching the pattern already used insemantic_info.py. Importedfieldfromdataclassesin both files.Tested that
import matterix_smworks standalone after the fix (HAS_ISAACLAB=False).Type of change
Checklist
pre-commitchecks with<FULL_PATH_TO_ISAACLAB>/isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there