Build SDK before testnet UI bundles - #163
Merged
Merged
Conversation
CI already compiles @commonality/sdk before consumers. The deploy job only ran npm ci, so ui build:ipfs failed on missing @commonality/sdk/* types.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Forced UI deploy 33815432667 got past the missing
operator-addresses.envfile, thenuibuild:ipfsfailed withCannot find module '@commonality/sdk/...'. CI already runsnpm run build --workspace=@commonality/sdkafternpm ci; the deploy job did not.What
scripts/deploy-testnet.shbuilds the SDK once before the domain loop. That script is now treated as UI-related (#161), so promoting this to master should actually publish UI without anotherforce_uidispatch.