Verification-stack descriptor contract + deployer: repos declare their full stack, Factory brings it up - #314
Conversation
Rebase assessment: do not rebase — this PR is fully superseded. Recommend closing it.I was dispatched to rebase The brief described conflicts as "concentrated in 6 integration-point files." That understates it. The real merge produces 17 conflicts, 11 of them What happenedSame author, same morning, two parallel dispatches:
Seven minutes after this branch's commit, a sibling implementation was committed and merged the same day. #173 then carried this branch's exact code onto Evidence that it is the same code, not merely similarDescriptor — literal superset, zero loss. Deployer — same file, extended. Public API — 39 of 41 symbols already exported from Tests — all six, verbatim, plus one more. Every Files — all 19 exist on What merging this would costBecause the branch is 200 commits behind, its side of each conflict is the older side. Taking it would:
On issue #143 — do not re-dispatch as writtenWorth flagging, because it changes the follow-up: #143's primary acceptance criterion was never built, on either side. The issue specifies Cloudflare (Workers + Containers + D1/KV/R2/Queues/Hyperdrive) as the primary deploy kind, with Helm/kustomize/manifests/compose as escape hatches. Both this branch and So the remaining scope of #143 is the Cloudflare deploy kind — and this branch does not contribute to it. Rebasing it buys nothing toward the open work. Recommended:
CI and review state
I ran no local test suite: there is no merged tree to test, and the branch's own dependency set is 200 commits stale. The verification-stack code that matters is already covered green on I have not merged, closed, or pushed anything. Khaliq owns the merge gate; the close call is yours. |
|
Closing: this PR wraps a branch whose last commit is 2026-07-21, opened against a Reconciling +2378/-1 across 19 files written before 0.1.66→0.1.68, the relay fleet-client bounding work (#307), and the config-schema change would not be an honest review; the branch predates the assumptions the current code makes. Issue #143 stays open and still carries Not closing the issue — only this stale PR. The branch is left in place for reference. |
Publishes previously stranded Factory work for #143.
The implementer completed and pushed
factory/143-agentworkforce-factory-f9b704a7, but the terminal publish step failed for five days with403 Resource not accessible by integration: the workspace's GitHub connection named a personal-account App installation (148356820) instead of the AgentWorkforce org installation (137532802). See AgentWorkforce/relayfile-cloud#155.The connection has been repointed, and this PR is the acceptance test for that repair — published through Factory's own publish path, authored by
app/agent-relay-code.The branch is well behind
mainand has not been re-reviewed since it was stranded. Opened for review only; not for merge.Refs #143
Summary by cubic
Introduces a repository-owned verification-stack contract and deployer so repos declare their full verification environment and Factory brings it up in Kubernetes. This replaces ad-hoc env setup with a validated descriptor, bounded health gates, seed steps, and resolved local endpoints.
@agent-relay/factory/verification-stack.schema.jsonand exports descriptor types, loader, and errors (VerificationStackDescriptorSchema,VerificationStackDescriptorError, etc.).VerificationStackDeployerwith HTTP/TCP/exec probes, Helm/Kustomize/manifest/docker-compose(viakompose) support, and endpoint port-forwards. AddsKubernetesEnvironmentProviderthat provisions per-run namespaces and deletes them idempotently.src/index.tsand shipsschemas/in the package. Requireskubectl,helm, andkomposeon PATH and a Kubernetes context/kubeconfig.verification-stack-e2ethat creates a Kind cluster and runsnpm run test:stack-e2e(newtsxdev dependency)..factory/verification-stack.yamlwith only opaque secret/config references and provide aVerificationStackReferenceResolver; existing repos are unaffected until they add the descriptor.Written for commit c35e66d. Summary will update on new commits.