fix(workbench): wrap long URLs in the error card so it stops overflowing the viewport - #40
Merged
Merged
Conversation
…ing the viewport Claude-Session: https://claude.ai/code/session_01URDpaxhXyPLWnUQtvowNyM
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closed
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last actionable item in #11.
Found by dispatching real touch events, not by resizing a window
#11 exists because viewport emulation produced false confidence the first time. So this run used Playwright Chromium with
hasTouch,isMobile,deviceScaleFactor: 3, gestures dispatched throughInput.dispatchTouchEventover CDP, signed in as a real seeded user against the Neondevbranch.The bug
At a 768 px tablet viewport the Workbench error card measured
scrollWidth842 in a 768 px viewport. Cause: the card printserror.message, which embeds a presigned storage URL — one long unbroken token with no break opportunity.break-allfixes it.Measured before and after:
The more important finding: most of #11 is not applicable
The Konva canvas never mounts on a phone.
WorkbenchPage.tsx:75gates onwindow.innerWidth < 768and renders "Open this on a larger screen — the roof layout workbench needs precise drag-and-drop, rotation, and multi-select gestures that work best on a desktop or tablet."So the issue's gesture checklist — pinch zoom, two-finger pan, multi-touch rotation, marquee select at 360 px — describes interactions the product deliberately refuses to offer at that width. That is a shipped product decision, not an untested gap. Gestures on real tablet hardware at ≥768 px remain unverified.
Also confirmed clean at both 360 and 768: no horizontal overflow on AnalysisPage, sign-in completes at 360 px, and no
<input type="number">renders narrower than 80 px (the row #34 stacked).One thing left open, recorded not fixed
The run hit
Failed to load rooftop image from <r2 host>— the URL reaching the browser was not presigned in this environment, which is why the canvas could not mount even at 768 px. It may be dev-environment-specific or a real defect; it is logged as item 5 in the newdocs/uat.mdsession rather than guessed at here.https://claude.ai/code/session_01URDpaxhXyPLWnUQtvowNyM