Skip to content

fix(workbench): wrap long URLs in the error card so it stops overflowing the viewport - #40

Merged
AlaskanTuna merged 1 commit into
mainfrom
fix/workbench-error-overflow
Aug 25, 2026
Merged

fix(workbench): wrap long URLs in the error card so it stops overflowing the viewport#40
AlaskanTuna merged 1 commit into
mainfrom
fix/workbench-error-overflow

Conversation

@AlaskanTuna

Copy link
Copy Markdown
Owner

Closes the last actionable item in #11.

Found by dispatching real touch events, not by resizing a window

#11 exists because viewport emulation produced false confidence the first time. So this run used Playwright Chromium with hasTouch, isMobile, deviceScaleFactor: 3, gestures dispatched through Input.dispatchTouchEvent over CDP, signed in as a real seeded user against the Neon dev branch.

The bug

At a 768 px tablet viewport the Workbench error card measured scrollWidth 842 in a 768 px viewport. Cause: the card prints error.message, which embeds a presigned storage URL — one long unbroken token with no break opportunity. break-all fixes it.

Measured before and after:

before:  no horizontal overflow on workbench — FAIL  scrollWidth=842 clientWidth=768
after:   no horizontal overflow on workbench — PASS  scrollWidth=768 clientWidth=768

The more important finding: most of #11 is not applicable

The Konva canvas never mounts on a phone. WorkbenchPage.tsx:75 gates on window.innerWidth < 768 and renders "Open this on a larger screen — the roof layout workbench needs precise drag-and-drop, rotation, and multi-select gestures that work best on a desktop or tablet."

So the issue's gesture checklist — pinch zoom, two-finger pan, multi-touch rotation, marquee select at 360 px — describes interactions the product deliberately refuses to offer at that width. That is a shipped product decision, not an untested gap. Gestures on real tablet hardware at ≥768 px remain unverified.

Also confirmed clean at both 360 and 768: no horizontal overflow on AnalysisPage, sign-in completes at 360 px, and no <input type="number"> renders narrower than 80 px (the row #34 stacked).

One thing left open, recorded not fixed

The run hit Failed to load rooftop image from <r2 host> — the URL reaching the browser was not presigned in this environment, which is why the canvas could not mount even at 768 px. It may be dev-environment-specific or a real defect; it is logged as item 5 in the new docs/uat.md session rather than guessed at here.

https://claude.ai/code/session_01URDpaxhXyPLWnUQtvowNyM

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 90c27b9c-39fb-4881-ab5b-5d2c35b30676


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AlaskanTuna
AlaskanTuna merged commit 4104c53 into main Aug 25, 2026
3 checks passed
@AlaskanTuna
AlaskanTuna deleted the fix/workbench-error-overflow branch August 25, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant