Skip to content

fix(pdf): translate the report disclaimers that existed only in English - #42

Merged
AlaskanTuna merged 1 commit into
mainfrom
fix/pdf-disclaimer-locales
Aug 25, 2026
Merged

fix(pdf): translate the report disclaimers that existed only in English#42
AlaskanTuna merged 1 commit into
mainfrom
fix/pdf-disclaimer-locales

Conversation

@AlaskanTuna

Copy link
Copy Markdown
Owner

Found by auditing every locale file for key parity, not just the ones this session touched.

The gap

pdf.json carried seven strings under page8.disclaimers in en that were absent from both ms and zh:

tnbTariff · afaRate · eeiRebate · solarGeneration · creditForfeiture · systemCost · paybackProjections

These are the financial and regulatory disclaimers on the exported PDF — the text that says estimates are based on RP4 tariffs, that AFA changes monthly, that excess NEM credits are forfeited at year end, that payback ignores maintenance and inverter replacement, and that system cost should be confirmed with a SEDA-registered installer.

A Malay or Chinese user exporting a report was getting the numbers without the caveats attached to them. Given the README already frames SolarSim as an assessment tool rather than a quotation, that is the wrong thing to silently drop.

Pre-existing, not a regression

git log 4a1b14f..HEAD -- frontend/src/locales/*/pdf.json returns nothing — untouched by any of this session's 16 PRs. It predates them, which is exactly why a whole-directory parity check was worth running rather than only re-checking edited files.

Translated at the register already used in ms/zh (formal anda, 您), keeping the Malaysian domain terms intact — TNB, RP4, AFA, EEI, NEM, SEDA, PETRA, BOS.

Verified

  • All 15 locale files now agree across en/ms/zh — full structural parity, checked file by file.
  • pnpm --filter frontend exec tsc --noEmit 0 errors · 216 frontend tests pass · Prettier clean.

Other audit checks, all clean

  • Demo coordinates identical between frontend/src/lib/demoLocations.ts and prisma/seedDemoLocations.ts (the deliberate duplication has not drifted).
  • No video binary has ever been committed to any branch.
  • Zero TODO/FIXME/@ts-ignore/: any introduced across this session's 16 PRs.
  • render.yaml covers every required key in backend/src/config/env.ts.

https://claude.ai/code/session_01URDpaxhXyPLWnUQtvowNyM

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2b65598b-d55d-480f-8af5-0b6604a4cdb8


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AlaskanTuna
AlaskanTuna merged commit 4948895 into main Aug 25, 2026
3 checks passed
@AlaskanTuna
AlaskanTuna deleted the fix/pdf-disclaimer-locales branch August 25, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant