Conversation
IsActiveClustersError returned on the first CONFLICT-coded error, so an active-clusters conflict reported after another conflict was never seen. The delete then surfaced the raw GraphQL dump instead of the force_destroy_clusters hint. Match on code and message together and keep scanning, like IsNotFoundError does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsActiveClustersErrorreturned from inside the loop on the firstCONFLICT-coded error:When the API reports two conflicts and the active-clusters one is not first, the function answers
falseand never looks at the rest.FormatDeleteErrorthen falls back to dumping the raw GraphQL messages instead of telling the user to setforce_destroy_clusters=true.Now the code and message are matched together and the loop keeps scanning, which is what
IsNotFoundErroralready does.TestIsActiveClustersError_ConflictAfterOtherConflictfails on master and passes with the fix. The five existing cases still pass.