Conversation
Prod and dev schemas are now identical: prod serves mfa, and the ClickHouse cluster/keeper inputs are no longer declared by either.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65242bd2e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| detail func(value string) string | ||
| } | ||
|
|
||
| // UniqueObjectAttribute rejects sets whose object elements repeat a value for the given string attribute. |
There was a problem hiding this comment.
Remove this comment because it merely paraphrases the function name and signature rather than documenting a non-obvious invariant or external constraint; the repository explicitly prohibits comments that restate what code does and doc comments on short functions.
AGENTS.md reference: AGENTS.md:L94-L97
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Removed in bcc66f1, along with the description param that made the call sites read as positional string soup.
Exposes eksAccessEntries, added to the public API in Altinity/cloud#1888: the IAM principals granted access to the environment's EKS API. Modeled as a set because order is irrelevant and the API replaces the whole list on update. Capped at 8 entries, principals must be unique. The set validator that enforced unique external bucket names is now a generic UniqueObjectAttribute shared by both.
65242bd to
bcc66f1
Compare
1 participant
Adds
eks_access_entriestoaltinitycloud_env_aws(resource and data source), exposing the IAM principals granted access to the environment's EKS API added to the public API in Altinity/cloud#1888.{principal_arn, access_level}, max 8,ADMIN/READ_WRITE/READ_ONLYUniqueObjectAttribute, shared with external bucketsThe separate
chore: sync graphql sdkcommit picks up unrelated prod drift: prod now servesmfa, and the ClickHouse cluster/keeper inputs are gone from both prod and dev, so the ClickHouse feature branches can no longer regenerate.