fix invalid syntax in flake.nix overlay - #111
Merged
Merged
Conversation
Owner
|
Hey, thanks for reporting this issue and resolving it as well. |
|
Ahh, I didn't think to test the overlay and because nix is lazy, I didn't catch the mistake. Sorry! With your fix it evaluates successfully for me. So LGTM! |
|
Side note: maybe I should eventually add some smoke tests to ci for all the flake outputs... |
Owner
|
Thanks for the quick look, @delet-this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous commit to this file introduced invalid syntax to the overlay part of the flake, most likely accidentally. I use the manual method and not the module, so for me the flake failed to evaluate. I just needed to remove the import keyword and it works as it did before.