Skip to content

Keep the manual aligned with current links and resources - #4565

Open
Tu-shen2025 wants to merge 1 commit into
Anvil-Dev:dev/1.21/1.6from
Tu-shen2025:codex/audit-pr2
Open

Keep the manual aligned with current links and resources#4565
Tu-shen2025 wants to merge 1 commit into
Anvil-Dev:dev/1.21/1.6from
Tu-shen2025:codex/audit-pr2

Conversation

@Tu-shen2025

Copy link
Copy Markdown
Contributor

Refresh the audited pages so links, recipe/resource references, and removed-resource entries match the current documentation surface.

Constraint: Scope is limited to PR2 audit items and preserves existing file formatting.

Rejected: Unrelated audit findings and cleanup | They belong to separate PRs or are outside this release.

Confidence: high

Scope-risk: narrow

Directive: Keep future manual references grounded in current generated resources.

Tested: doc_audit, targeted link/resource checks, and git diff --check.

Not-tested: No game runtime test; this is a docs-only change.

Refresh the audited pages so links, recipe/resource references, and removed-resource entries match the current documentation surface.

Constraint: Scope is limited to PR2 audit items and preserves existing file formatting.

Rejected: Unrelated audit findings and cleanup | They belong to separate PRs or are outside this release.

Confidence: high

Scope-risk: narrow

Directive: Keep future manual references grounded in current generated resources.

Tested: doc_audit, targeted link/resource checks, and git diff --check.

Not-tested: No game runtime test; this is a docs-only change.
@Gugle2308

Copy link
Copy Markdown
Collaborator

Both stale recipe IDs were the only two occurrences and both are fixed in this PR. The PR is a scoped, accurate documentation refresh. Let me compile the review.

Verification summary — all claims confirmed against target branch dev/1.21/1.6 (FETCH_HEAD 5ff6ee4):

Change Verified
Recipe smithing/transcendence_anviltwo_to_one_smithing/transcendence_anvil ✅ Old path doesn't exist; new path exists in generated recipes (type anvilcraft:two_to_one_smithing)
014.md: "up to four smithing templates" ✅ 221_ember_smithing_table.md#template-dissociation says "At most 4 selections, i.e. at most 4 new templates"
transcendium_upgrade_smithing_template removal ✅ Item NOT registered in ModItems.java (only royal_steel/frost_metal/ember_metal/permutation/deformation/two_to_one/four_to_one/eight_to_one exist) — was a dangling ref; only lingering trace is orphaned lang keys
transcendence_smithing_table replacement ✅ Registered block (ModBlocks.java:881, .lang("Transcendence Smithing Table"), zh_cn lang 超限锻造台)
sea_heart_shellancient_sea_reef icon ancient_sea_reef registered (block+item+model); sea_heart_shell has only leftover texture files, no registration
Anchor #过筛#meshing ✅ 007_struct/000_item_processing.md:78 # Meshing
Anchor #Cooking#fast-cooking / #烹饪#快速烹饪 ✅ 007:104 # Fast Cooking / zh_cn # 快速烹饪
Anchor #铁砧撞击合成#anvil-impact-crafting ✅ 215_large_electromagnet.md:39 # Anvil Impact Crafting
Anchor #功能#function ✅ 210_giant_anvil.md:36 # Function
Anchor #获取#acquisition ✅ 100_amulet.md:37 # Acquisition
#模板解离 (zh_cn, kept) ✅ 221 zh_cn:42 # 模板解离
EOF/no-newline markers (2) ✅ Pre-existing on target branch, formatting preserved

代码审查摘要 — PR #4565

操作: opened
范围: 16 个文件 (0 Java, 0 新增, 0 删除) / 206 行 diff — 纯文档(ageratum 手册)PR
分支: codex/audit-pr2 → dev/1.21/1.6

✅ 变更核实(全部通过交叉验证)

这是一次高质量的手册同步刷新,所有改动都在目标分支 dev/1.21/1.6 上逐一验证为真实修正,而非凭空改动:

变更 验证结果
<recipe id="anvilcraft:smithing/transcendence_anvil"/>two_to_one_smithing/transcendence_anvil(en_us 311 + zh_cn 313) ✅ 旧 ID 在目标分支不存在;新 ID 存在于生成配方(type anvilcraft:two_to_one_smithing,输入 ember_anvil + frost_anvil + multiphase_transcendium)。且这是全仓仅有的两处旧 ID,无遗漏
014.md「获得 transcendium_upgrade_smithing_template」→「最多获得 4 个锻造模板」 ✅ 与 221_ember_smithing_table.md#template-dissociation 机制一致("At most 4 selections, i.e. at most 4 new templates")。旧文字描述的是已删除的机制
<ref item="anvilcraft:transcendium_upgrade_smithing_template"/> 移除(014 + 312 en/zh) ✅ 该物品未注册于 ModItems.java(现存模板只有 royal_steel / frost_metal / ember_metal / permutation / deformation / two_to_one / four_to_one / eight_to_one)——原引用是悬挂引用,删除正确
312_transcendium.md 改用 <ref item="anvilcraft:transcendence_smithing_table"/> ✅ 已注册方块(ModBlocks.java:881,REGISTRUM .lang("Transcendence Smithing Table"),zh_cn lang 超限锻造台,且有独立 ageratum 页面 zh_cn/311_transcendence_smithing_table.md)
008_recipe/index.md icon sea_heart_shellancient_sea_reef ancient_sea_reef 已注册(blockstate/model/loot/recipe/advancement 齐全);sea_heart_shell 仅剩孤立贴图文件,无注册
锚点 #过筛#meshing#Cooking#fast-cooking#铁砧撞击合成#anvil-impact-crafting#功能#function#获取#acquisition ✅ 全部与目标页面实际标题匹配(# Meshing# Fast Cooking# Anvil Impact Crafting# Function# Acquisition);zh_cn 侧 #快速烹饪#模板解离 亦匹配中文标题

🟢 看起来不错

  • 格式保持:2 处 "No newline at end of file"(zh_cn 100_heater.md、008_recipe/index.md)在目标分支上原本就没有尾换行,PR 未引入新问题
  • 范围纪律:严格限定在 PR2 audit 项内,无无关清理;en/zh 双语同步修改,无漏改(旧 recipe ID、旧物品引用均为全仓仅剩实例)
  • 一致性:en_us 与 zh_cn 的语义改动完全对应("最多获得 4 个锻造模板" / "使用超限锻造台升级工具")

📋 声称验证表

声称 状态
修复 recipe/resource 引用 ✅ 全部验证
更新移除资源条目(transcendium_upgrade_smithing_template、sea_heart_shell) ✅ 全部验证
锚点与当前页面标题对齐 ✅ 全部验证
范围限于 PR2 audit 项
保留现有文件格式
git diff --check 通过 ✅(无空白错误;2 个 no-newline 为既有状态)

结论: APPROVE — 纯文档 PR,16 处改动全部交叉验证为真实修正(修复 1 个失效 recipe ID、2 处悬挂物品引用、1 处失效图标、7 个失效锚点、1 处过时机制描述),双语一致,无格式回归,符合声明的范围和置信度。

💡 非阻塞建议

  • orphaned lang keystranscendium_upgrade_smithing_template 仍残留在 10+ 个语言文件(de/es/fr/ja/ko/lzh/ru/zh_cn/zh_hk/zh_meme 等)中。这是已删除物品的孤立翻译键,清理它属于 lang 清理范畴,可另开 PR(符合本 PR「拒绝无关清理」的范围纪律,此处仅提示)。
  • en_us 侧暂无 transcendence_smithing_table 的专属 ageratum 页面(仅 zh_cn 有 311_transcendence_smithing_table.md),若后续补上可让跨语言手册结构更对称——同样属范围外建议。

由 Hermes Agent 审查

@Gugle2308

Copy link
Copy Markdown
Collaborator

💾 Self-improvement review: Patched SKILL.md in skill 'documentation-pr-review' (1 replacement).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants